WN Update: SignalR ActivitySource #34183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@BrennanConroy, Internal preview of updated SignalR section for Improved Activities for review. I had added the 2nd activity a while back as an include but accidentally didn't replace the link in the What's New parent topic. Now it shows both server and client activities. |
tdykstra
approved these changes
Nov 19, 2024
Contributor
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
LGTM. One nit suggestion.
aspnetcore/release-notes/aspnetcore-9/includes/signalrActivities.md
Outdated
Show resolved
Hide resolved
…es.md Review suggestion by tdykstra Co-authored-by: Tom Dykstra <[email protected]>
BrennanConroy
approved these changes
Nov 20, 2024
| builder.Services.AddRazorPages(); | ||
| builder.Services.AddSignalR(); | ||
|
|
||
| builder.Services.AddRazorPages(); |
Contributor
Author
There was a problem hiding this comment.
Thanks for the catch Brennan, sorry I missed that. Correcting....
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal preview of updated SignalR section for Improved Activities
Added a missing new activity source for SignalR.
Fixes #33546
Why:
I had previously added a new include file with the update many weeks ago which was never referenced in the What's New, rather than updating the original include. Fixed that so the update is in the original include instead, and removed the duplicate include.
Also:
Internal previews